Skip to content

fix: address issue #4587 — Promote PortPolicyNone Feature Gate from Beta to Stable#4599

Open
santoshguru-11 wants to merge 1 commit into
agones-dev:mainfrom
santoshguru-11:fix/issue-4587-promote-portpolicynone-feature-gate-from
Open

fix: address issue #4587 — Promote PortPolicyNone Feature Gate from Beta to Stable#4599
santoshguru-11 wants to merge 1 commit into
agones-dev:mainfrom
santoshguru-11:fix/issue-4587-promote-portpolicynone-feature-gate-from

Conversation

@santoshguru-11
Copy link
Copy Markdown

Fixes #4587: Promote PortPolicyNone Feature Gate from Beta to Stable


Contributed via oss-contrib · @santoshguru-11

@santoshguru-11
Copy link
Copy Markdown
Author

Updated the PR with a complete fix for the PortPolicyNone → Stable promotion.

Changes in addition to the config/metadata files:

  • pkg/apis/agones/v1/gameserver.go: removed all FeatureEnabled(FeaturePortPolicyNone) guards:
    • Removed the port policy validation block that rejected portPolicy: None when the gate was off
    • Simplified host port assignment — if p.PortPolicy != None (unconditional)
    • Simplified Status() — returns containerPort unconditionally when portPolicy == None
  • pkg/cloudproduct/gke/gke.go: removed the feature gate check in GKE Autopilot port policy validation; None is now always a valid policy; simplified the Range check to drop the redundant gate condition

Also squashed all commits into a single clean commit with Signed-off-by included.

Let me know if anything else needs adjusting!

PortPolicyNone has been enabled by default since v1.49.0 and is now
ready for promotion to Stable.

Changes:
- pkg/util/runtime/features.go: move FeaturePortPolicyNone from Beta
  to Stable section in featureDefaults so old gate strings parse cleanly
  on upgrade
- pkg/apis/agones/v1/gameserver.go: remove all FeatureEnabled(FeaturePortPolicyNone)
  guards — fold portPolicy None validation, hostPort assignment, and
  Status() port return to unconditional logic
- pkg/cloudproduct/gke/gke.go: remove FeaturePortPolicyNone gate from
  GKE Autopilot port policy validation; None is always valid; simplify
  Range check to drop the redundant feature-gate condition
- install/helm/agones/defaultfeaturegates.yaml: move PortPolicyNone
  from Beta to Stable section
- build/Makefile: remove PortPolicyNone from BETA_FEATURE_GATES
- cloudbuild.yaml: remove PortPolicyNone=false from inverted e2e-runner
  feature gate config
- site/content/en/docs/Guides/feature-stages.md: move row from Beta
  table to Stable table
- test/upgrade/versionMap.yaml: add stableGates entry for PortPolicyNone
  in Dev version mapping

Fixes agones-dev#4587

Signed-off-by: santoshguru-11 <darbhasantosh11@gmail.com>
@santoshguru-11 santoshguru-11 force-pushed the fix/issue-4587-promote-portpolicynone-feature-gate-from branch from 60554f5 to eb14da3 Compare June 2, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Promote PortPolicyNone Feature Gate from Beta to Stable

1 participant