fix: address issue #4587 — Promote PortPolicyNone Feature Gate from Beta to Stable#4599
Open
santoshguru-11 wants to merge 1 commit into
Conversation
Author
|
Updated the PR with a complete fix for the PortPolicyNone → Stable promotion. Changes in addition to the config/metadata files:
Also squashed all commits into a single clean commit with Let me know if anything else needs adjusting! |
PortPolicyNone has been enabled by default since v1.49.0 and is now ready for promotion to Stable. Changes: - pkg/util/runtime/features.go: move FeaturePortPolicyNone from Beta to Stable section in featureDefaults so old gate strings parse cleanly on upgrade - pkg/apis/agones/v1/gameserver.go: remove all FeatureEnabled(FeaturePortPolicyNone) guards — fold portPolicy None validation, hostPort assignment, and Status() port return to unconditional logic - pkg/cloudproduct/gke/gke.go: remove FeaturePortPolicyNone gate from GKE Autopilot port policy validation; None is always valid; simplify Range check to drop the redundant feature-gate condition - install/helm/agones/defaultfeaturegates.yaml: move PortPolicyNone from Beta to Stable section - build/Makefile: remove PortPolicyNone from BETA_FEATURE_GATES - cloudbuild.yaml: remove PortPolicyNone=false from inverted e2e-runner feature gate config - site/content/en/docs/Guides/feature-stages.md: move row from Beta table to Stable table - test/upgrade/versionMap.yaml: add stableGates entry for PortPolicyNone in Dev version mapping Fixes agones-dev#4587 Signed-off-by: santoshguru-11 <darbhasantosh11@gmail.com>
60554f5 to
eb14da3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4587: Promote
PortPolicyNoneFeature Gate from Beta to Stable